improve some basic structs #216
Conversation
| #[cfg_attr(feature = "serde", derive(serde::Serialize, serde::Deserialize))] | ||
| pub struct Anchor(pallas::Base); | ||
|
|
||
| impl Anchor { |
There was a problem hiding this comment.
Do you think there is a need for a separate type for the anchor? Technically, the root is also a node.
There was a problem hiding this comment.
For now, the Anchor is exactly the root. I'm considering extending the Anchor struct. We probably will add more parameters to Anchor, like the block number, epoch, etc., so that we can add constraints in circuits and check them publicly. We discussed the proposal before but have yet to decide what to add.
Besides, Node is a little confusing; we also have the blockchain Node. I don't tend to use the Node struct outside of the Merkle tree and may make it private later.
Does it make any sense? If not, I can revert it.
There was a problem hiding this comment.
Yeah, it does. However, the executor does work with Node objects too when constructing the tree.
NoteCommitmentandAnchor) inShieldedResultAnchor, to denote the roof of the Merkle tree.ActionInstancetoActionPublicInputs